Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dep): reth db workspace #4782

Merged
merged 1 commit into from
Sep 26, 2023
Merged

chore(dep): reth db workspace #4782

merged 1 commit into from
Sep 26, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Always use reth-db as workspace dep.

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-dependencies Pull requests or issues that are about dependencies labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #4782 (4a2b34b) into main (6d634e9) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

see 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.51% <ø> (-0.01%) ⬇️
unit-tests 63.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.23% <ø> (ø)
blockchain tree 83.69% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.49% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 49.51% <ø> (-0.47%) ⬇️
networking 76.87% <ø> (+0.03%) ⬆️
rpc 57.69% <ø> (+<0.01%) ⬆️
consensus 62.84% <ø> (ø)
revm 28.33% <ø> (ø)
payload builder 8.20% <ø> (ø)
primitives 86.49% <ø> (-0.01%) ⬇️

@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 7024e9a Sep 26, 2023
24 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/reth-db-workspace-dep branch September 26, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @shekhirin