Skip to content

feat: add PrecompileCacheMap::cache_for_address and test #16197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

fgimenez
Copy link
Member

follow-up of #16191, adds a helper method and regression test

@fgimenez fgimenez self-assigned this May 13, 2025
@fgimenez fgimenez added C-perf A change motivated by improving speed, memory usage or disk footprint C-test A change that impacts how or what we test A-engine Related to the engine implementation labels May 13, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker May 13, 2025
@fgimenez fgimenez moved this from Backlog to In Review in Reth Tracker May 13, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@@ -11,8 +10,8 @@ use std::sync::Arc;
pub struct PrecompileCacheMap(HashMap<Address, PrecompileCache>);

impl PrecompileCacheMap {
pub(crate) fn entry(&mut self, address: Address) -> Entry<'_, Address, PrecompileCache> {
self.0.entry(address)
pub(crate) fn cache_for_address(&mut self, address: Address) -> PrecompileCache {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Reth Tracker May 13, 2025
@mattsse mattsse added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 805fb10 May 13, 2025
45 checks passed
@mattsse mattsse deleted the fgimenez/precompile-cache-map-test branch May 13, 2025 21:36
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Related to the engine implementation C-perf A change motivated by improving speed, memory usage or disk footprint C-test A change that impacts how or what we test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants