chore: Add metrics for supervisor RPC error #16111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes I think it will be useful for debugging interop + developing recovery mechanism + perf optimisation we need a separate grafana board for op-reth #15724 |
emhane
reviewed
May 12, 2025
| /// Counter for the number of times the chain database was uninitialized | ||
| pub(crate) uninitialized_chain_database_count: Counter, | ||
| /// Counter for the number of times data was skipped | ||
| pub(crate) skipped_data_count: Counter, |
There was a problem hiding this comment.
I think we can create a single metric 'supervisor_api_errors' and have the error_type as tags to the metric. Let me know what you think.
There was a problem hiding this comment.
what are the benefits? link to docs for the type you are referring to?
emhane
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16080