feat: extended AddOns with functions that can modify the StageSet(wip) #16039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rimeeeeee
requested review from
mattsse,
Rjected,
onbjerg and
klkvr
as code owners
Rimeeeeee
commented
May 2, 2025
| R: Future<Output = eyre::Result<E>> + Send, | ||
| E: Future<Output = eyre::Result<()>> + Send, | ||
| { | ||
| self.add_ons.stage_installer = None; |
There was a problem hiding this comment.
kept this as none for now
mattsse
requested changes
May 2, 2025
Comment on lines
14
to
15
| /// Custom stage installers | ||
| pub stage_installer: Option<Box<dyn BoxedInstallStages<Node>>>, |
| /// Installs custom stages into the stage set builder with a boxed future. | ||
| fn on_stages( | ||
| self: Box<Self>, | ||
| stages: StageSetBuilder<Node>, |
crates/node/builder/src/lib.rs
Outdated
| @@ -46,6 +46,9 @@ pub use aliases::*; | |||
| /// Support for installing the ExExs (execution extensions) in a node. | |||
| pub mod exex; | |||
|
|
|||
| /// Support for installing the stages in a node. | |||
| pub mod install_stages; | |||
There was a problem hiding this comment.
let's just call this stages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16032