feat: introduce Receipt69 variant #15827
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 1, 2025
There was a problem hiding this comment.
cool, ty. almost there, some additional nits
what we also need is proper version aware encoding and decoding
https://github.com/paradigmxyz/reth/blob/main/crates/net/eth-wire-types/src/message.rs#L115-L115
| feature = "serde", | ||
| serde(bound = "N::Receipt: serde::Serialize + serde::de::DeserializeOwned") | ||
| )] | ||
| Receipts69(RequestPair<Receipts<N::Receipt>>), |
There was a problem hiding this comment.
this should use the 69 variant, right?
crates/net/network/src/message.rs
Outdated
Comment on lines
193
to
207
| Ok(res) => { | ||
| let receipts = res | ||
| .into_iter() | ||
| .map(|batch| { | ||
| batch | ||
| .into_iter() | ||
| .map(|r| ReceiptWithBloom { | ||
| receipt: r, | ||
| logs_bloom: Default::default(), | ||
| }) | ||
| .collect() | ||
| }) | ||
| .collect(); | ||
| let request = RequestPair { request_id: id, message: Receipts(receipts) }; | ||
| Ok(EthMessage::Receipts69(request)) |
There was a problem hiding this comment.
this is unneccessary if we use the 69 varaint for Receipts69, see above
stevencartavia
force-pushed
the
Receipts69-variant
branch
from
9bb89fa to
018f6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15510