Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash ExEx task when the ExEx future returns #7630

Closed
Tracked by #7549
onbjerg opened this issue Apr 14, 2024 · 0 comments · Fixed by #7633
Closed
Tracked by #7549

Crash ExEx task when the ExEx future returns #7630

onbjerg opened this issue Apr 14, 2024 · 0 comments · Fixed by #7633
Labels
A-exex Execution Extensions C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 14, 2024

Describe the feature

If an ExEx future returns it means it has stopped processing incoming notifications which we will (at least for now) treat as a fatal error. We assume that users running ExEx's want them to be up to date, and we have built the system under this assumption.

Because of this, we should panic here even if the ExEx returns Ok(()):

exex.await.unwrap_or_else(|_| panic!("exex {} crashed", id))
});

Additional context

No response

@onbjerg onbjerg added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-exex Execution Extensions labels Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant