-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExEx metrics panels #7572
Comments
Would love to take this on |
Cool, thanks @mw2000! Let me know if you get stuck 😄 Do you have a rough timeline? |
Ideally this weekend! I'll take a first pass at it today in case I have more questions @onbjerg |
@onbjerg here's a first pass at it -> #7605 Pretty much used similar panels that we had for blockchain_tree_canonical_chain_height. A bit green when it comes to grafana dashboards, but I was seeing the following on my end: As opposed to what the blockchain_tree_canonical_chain_height panel looks like: Is there a misconfig in the code for the exex panels somewhere? I'll also double check from my side in the meantime |
No, the reason you don't have any data is because you don't have any extensions installed - this is expected. It looks fine to me, can you also add panels for the manager metrics? |
@onbjerg that sounds good, let me go ahead and do that. Added, and PR out of draft + ready to review |
Describe the feature
We added metrics in #7340 and we should add panels for these
reth/crates/exex/src/manager.rs
Lines 26 to 34 in 81090da
reth/crates/exex/src/manager.rs
Lines 118 to 130 in 81090da
Additional context
No response
The text was updated successfully, but these errors were encountered: