Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poll_reserve to ExExHandle #7570

Closed
Tracked by #7549
onbjerg opened this issue Apr 11, 2024 · 2 comments
Closed
Tracked by #7549

Add poll_reserve to ExExHandle #7570

onbjerg opened this issue Apr 11, 2024 · 2 comments
Assignees
Labels
A-exex Execution Extensions C-debt Refactor of code section that is hard to understand or maintain

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 11, 2024

          no, we should just add the equivalent fo poll_reserve,

but can also do this separately, so no blocker here

Originally posted by @mattsse in #7340 (comment)

@onbjerg onbjerg added A-exex Execution Extensions C-debt Refactor of code section that is hard to understand or maintain labels Apr 11, 2024
@mw2000
Copy link
Contributor

mw2000 commented Apr 12, 2024

I took a first pass at this. From what I understood from your (@onbjerg) and @mattsse conversation, we want to separate the poll_reserve logic out into a new function on the ExExHandle level that the manager can call. Was a relatively low effort on my end, so let me know if major chunks are missing or if I got the context wrong.

@shekhirin
Copy link
Collaborator

#7610 (review)

@shekhirin shekhirin closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants