Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move reth-tracing to workspace dependency #4983

Closed
mattsse opened this issue Oct 11, 2023 · 1 comment · Fixed by #4986
Closed

move reth-tracing to workspace dependency #4983

mattsse opened this issue Oct 11, 2023 · 1 comment · Fixed by #4986
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 11, 2023

Describe the feature

TODO

  • add reth-tracing to workspace dep:

    reth/Cargo.toml

    Line 87 in 00a92f5

    [workspace.dependencies]
  • replace all reth-tracing = { path = "../../tracing" } with reth-tracing.workspace = true

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Oct 11, 2023
@supernovahs
Copy link
Contributor

I can take this

@supernovahs supernovahs mentioned this issue Oct 11, 2023
Merged
@mattsse mattsse linked a pull request Oct 11, 2023 that will close this issue
rpc tracing to workspace #4986
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc tracing to workspace supernovahs/reth
2 participants
@mattsse @supernovahs