Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies on Parity hashers #4797

Closed
Tracked by #4715
DaniPopes opened this issue Sep 26, 2023 · 0 comments · Fixed by #4804
Closed
Tracked by #4715

Remove dependencies on Parity hashers #4797

DaniPopes opened this issue Sep 26, 2023 · 0 comments · Fixed by #4804
Assignees
@rkrasiuk
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Sep 26, 2023 •
edited
Loading

Only used in prod in reth_primitives::proofs::KeccakHasher for compatibility with triehash:

plain_hasher v0.2.3
└── reth-primitives v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/primitives)

hash-db v0.15.2
└── reth-primitives v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/primitives)

triehash is used only for tests.

cc @rkrasiuk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkrasiuk rkrasiuk

Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(primitives): move KeccakHasher behind test-utils feature flag paradigmxyz/reth
2 participants
@rkrasiuk @DaniPopes