You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rakita opened this issue
Sep 15, 2023
· 3 comments
Labels
A-dbRelated to the databaseC-debtRefactor of code section that is hard to understand or maintainS-staleThis issue/PR is stale and will close with no further activity
the naming is very confusing to me, because writing reverts results in wiped storage, because this does not actually write anything and instead deletes?
I inherited this, can bikeshed a little on this, should be fruitful.
little history, this pattern was used when we still were not sure how to handle Provider and needed to decide on the pattern for how to write things to the database. At that point in time this was one of the promising paths that we had.
What we have decided and have now is @joshieDo had split the Provider with the traits so I think this should be moved there and have BundeStateProvider trait that will have commit_state(bundle: State) and commit_reverts(reverts:Reverts). This feels nicer imo and it shouldn't be a big change.
The text was updated successfully, but these errors were encountered:
rakita
added
C-debt
Refactor of code section that is hard to understand or maintain
A-db
Related to the database
labels
Sep 15, 2023
A-dbRelated to the databaseC-debtRefactor of code section that is hard to understand or maintainS-staleThis issue/PR is stale and will close with no further activity
Comment from here: #3512 (comment)
The text was updated successfully, but these errors were encountered: