Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a custom enum for ExEx WAL errors #11423

Open
Tracked by #11200
shekhirin opened this issue Oct 2, 2024 · 6 comments · May be fixed by #11789
Open
Tracked by #11200

Introduce a custom enum for ExEx WAL errors #11423

shekhirin opened this issue Oct 2, 2024 · 6 comments · May be fixed by #11789
Assignees
Labels
A-exex Execution Extensions C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

Currently, we use eyre::Result for errors in ExEx WAL, but we can do better with a custom thiserror-powered enum that has rich variants (with tuples/structs) to pass additional fields such as file_id.

https://github.com/search?q=repo:paradigmxyz/reth+path:crates/exex/exex/src/wal+eyre&type=code

Additional context

No response

@shekhirin shekhirin added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain A-exex Execution Extensions labels Oct 2, 2024
@jancris100
Copy link

can you assign this to me?

@shekhirin
Copy link
Collaborator Author

hey @jancris100, are you still working on this? Let me know if you need any help

@caglaryucekaya
Copy link
Contributor

Hey @shekhirin, I'd like to work on this since he seems to be not responding

@shekhirin
Copy link
Collaborator Author

@caglaryucekaya assigned! let me know if you have any questions :)

@caglaryucekaya
Copy link
Contributor

Should I still use eyre::Result and return the custom error as part of it, or not use the eyre::Result at all?

@shekhirin
Copy link
Collaborator Author

@caglaryucekaya we want a custom error enum that will be returned from functions as Result<_, WalError>

@caglaryucekaya caglaryucekaya linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants