Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit receipt version in OP RPC transaction #11164

Open
emhane opened this issue Sep 24, 2024 · 1 comment · May be fixed by #11440
Open

Deposit receipt version in OP RPC transaction #11164

emhane opened this issue Sep 24, 2024 · 1 comment · May be fixed by #11440
Assignees
@aroralanuk
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started S-needs-investigation This issue requires detective work to figure out what's going wrong

Comments

@emhane
Copy link
Member

emhane commented Sep 24, 2024

Describe the feature

What should we be setting the deposit receipt version field to in an op_alloy_rpc_types::Transaction?

reth/crates/optimism/rpc/src/eth/transaction.rs

Line 115 in f606b70

deposit_receipt_version: None, // todo: how to fill this field?

Additional context

No response
@emhane emhane added C-bug An unexpected or incorrect behavior S-needs-investigation This issue requires detective work to figure out what's going wrong A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started labels Sep 24, 2024
@aroralanuk
Copy link
Contributor

Can I take this?

@aroralanuk aroralanuk linked a pull request Oct 2, 2024 that will close this issue
Open
@mattsse mattsse mentioned this issue Oct 9, 2024
Open
@emhane emhane mentioned this issue Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aroralanuk aroralanuk

Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started S-needs-investigation This issue requires detective work to figure out what's going wrong
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rpc): support deposit_receipt_version in OpTxBuilder aroralanuk/reth
2 participants
@aroralanuk @emhane