Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trait method TransactionCompat::otterscan_api_truncate_input #11163

Open
emhane opened this issue Sep 24, 2024 · 2 comments
Open

Remove trait method TransactionCompat::otterscan_api_truncate_input #11163

emhane opened this issue Sep 24, 2024 · 2 comments
Assignees
@nadtech-hub
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes

Comments

@emhane
Copy link
Member

emhane commented Sep 24, 2024

Describe the feature

Remove

reth/crates/rpc/rpc-types-compat/src/transaction/mod.rs

Lines 72 to 75 in 94d1d87

/// Truncates the input of a transaction to only the first 4 bytes.
// todo: remove in favour of using constructor on `TransactionResponse` or similar
// <https://github.com/alloy-rs/alloy/issues/1315>.
fn otterscan_api_truncate_input(tx: &mut Self::Transaction);

in favour of alloy-rs/alloy#1346

Additional context

No response
@emhane emhane added S-blocked This cannot more forward until something else changes C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation D-good-first-issue Nice and easy! A great choice to get started labels Sep 24, 2024
@emhane
Copy link
Member Author

emhane commented Sep 24, 2024

blocked by alloy-rs/alloy#1346

@nadtech-hub
Copy link
Contributor

I would like to take on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadtech-hub nadtech-hub

Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nadtech-hub @emhane