Skip to content

Support multiple all eth protocol versions announced in HelloMessage #1101

Closed
@mattsse

Description

Describe the feature

as highlighted here:
https://t.me/paradigm_reth/1611

we're announcing support for eth66/67 by default in Hello but only check for a single version in the eth Status handshake.

if status.version != resp.version {
return Err(EthHandshakeError::MismatchedProtocolVersion {
expected: status.version,
got: resp.version,
}
.into())

the status message should also accept older versions if announced.

TODO

if we add this to Status directly, we can no longer derive Rlp
so perhaps we add a list of versions as a separate parameter to the handshake function

wdyt @Rjected

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

A-networkingRelated to networking in generalC-enhancementNew feature or requestD-good-first-issueNice and easy! A great choice to get started

Type

No type

Projects

  • Status

    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions