Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forcing of X11 backend in .desktop file #23

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

mellowawa
Copy link

@mellowawa mellowawa commented Feb 6, 2025

Urn is forced run in X11/XWayland by its .desktop file eventhough it works just fine when running nativly on Wayland.

@paoloose
Copy link
Owner

paoloose commented Feb 7, 2025

Thanks!

If I remember correctly the Wayland crash only occurred when you set the global-hotkeys to true (see #9)

Of course, this is not the case anymore, because hotkeys are forcibly disabled on Wayland (see #18)

Some time ago a user reported that global hotkeys were working just fine in Wayland (comment in #9)

On Nobora 40 (Fedora 40, KDE 6.1), if I remove the if conditional checking for wayland, global hotkeys work just fine. Could there be a compile flag or something so Wayland users can at least try global hotkeys.

But this is probably not be the case for all Wayland users, so I'll merge this and create a URN_FORCE_GLOBAL_HOTKEYS variable to force global hotkeys on Wayland.

@paoloose paoloose merged commit 60833a2 into paoloose:main Feb 7, 2025
1 check passed
@mellowawa
Copy link
Author

Global hotkeys on wayland should generaly work on a DE that supports it, like Kde Plasma or Hyprland, these allow you to enable apps to read all keyboard inputs even on wayland.

@paoloose
Copy link
Owner

paoloose commented Feb 7, 2025

Yeah but this is pretty unstable among different desktop environment and versions, they just can't agree on a single implementation lol. As far as I know, the way Hyprland implemented global shortcuts even deviated from the Wayland standard.

I prefer to keep global shortcuts disabled to prevent crashes and let users enable them at their own risk. At least until global hotkeys become more stable in the ecosystem. #19 will keep track of that.

I've also added notes in the readme faq and an application warning so users are aware of that. See 0486ff9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants