Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trait for HMAC #77

Open
seanaye opened this issue May 26, 2023 · 1 comment
Open

Use trait for HMAC #77

seanaye opened this issue May 26, 2023 · 1 comment

Comments

@seanaye
Copy link

seanaye commented May 26, 2023

I am using this as a wasm module in js server runtime. I think changing the HMAC signing to a trait based approach would allow wasm binaries to leverage window.crypto for HMAC signing instead of the hmac crate. This would reduce bundle size and increase compat wit wasm.

Will make PR for this

@paolobarbolini
Copy link
Owner

Sounds good. I wander whether it'd be better to go for a trait or instead have a Cargo.toml feature for deciding which crypto backend to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants