fix: empty params are handled as if they were not provided at all

panva · Aug 17, 2019 · a9e0f8c · a9e0f8c
1 parent 3397d65
commit a9e0f8c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/lib/helpers/params.js b/lib/helpers/params.js
@@ -10,7 +10,9 @@ module.exports = function getParams(whitelist) {
 
     const klass = class Params {
       constructor(params) {
-        whitelist.forEach((prop) => { this[prop] = params[prop]; });
+        whitelist.forEach((prop) => {
+          this[prop] = params[prop] || undefined;
+        });
       }
 
       toPlainObject() {

diff --git a/lib/helpers/validate_presence.js b/lib/helpers/validate_presence.js
@@ -3,7 +3,10 @@ const { InvalidRequest } = require('./errors');
 module.exports = function validatePresence(ctx, ...required) {
   const { params } = ctx.oidc;
   const missing = required.map((param) => {
-    if (params[param] === undefined) return param;
+    if (params[param] === undefined) {
+      return param;
+    }
+
     return undefined;
   }).filter(Boolean);
 

diff --git a/test/body_parser/body_parser.test.js b/test/body_parser/body_parser.test.js
@@ -78,7 +78,7 @@ describe('body parser', () => {
         .expect(200);
 
       expect(
-        spy.calledWithMatch({ oidc: { params: { scope: '' } } }),
+        spy.calledWithMatch({ oidc: { params: { scope: undefined } } }),
       ).to.be.true;
     });
   });