fix: interaction uid is now an alias to its jti, it is not stored any…

…more either
panva · Mar 24, 2021 · 2d85768 · 2d85768
1 parent 41f4cd8
commit 2d85768
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/example/my_adapter.js b/example/my_adapter.js
@@ -128,7 +128,6 @@ class MyAdapter {
      * - kind {string} - "Interaction" fixed string value
      * - exp {number} - timestamp of the interaction's expiration
      * - iat {number} - timestamp of the interaction's creation
-     * - uid {string} - the uid of the authorizing client's established session
      * - returnTo {string} - after resolving interactions send the user-agent to this url
      * - deviceCode {string} - [DeviceCode user flows only] deviceCode reference
      * - params {object} - parsed recognized parameters object

diff --git a/lib/actions/authorization/interactions.js b/lib/actions/authorization/interactions.js
@@ -105,7 +105,6 @@ module.exports = async function interactions(resumeRouteName, ctx, next) {
     prompt,
     lastSubmission: oidc.result,
     accountId: oidc.session.accountId,
-    uid,
     params: oidc.params.toPlainObject(),
     trusted: oidc.trusted,
     session: oidc.session,

diff --git a/lib/models/interaction.js b/lib/models/interaction.js
@@ -4,7 +4,7 @@ const epochTime = require('../helpers/epoch_time');
 const hasFormat = require('./mixins/has_format');
 
 module.exports = (provider) => class Interaction extends hasFormat(provider, 'Interaction', instance(provider).BaseModel) {
-  constructor(id, payload) {
+  constructor(jti, payload) {
     if (arguments.length === 2) {
       if (payload.session instanceof instance(provider).BaseModel) {
         const { session } = payload;
@@ -26,12 +26,20 @@ module.exports = (provider) => class Interaction extends hasFormat(provider, 'In
         }
       }
 
-      super({ ...payload, jti: id });
+      super({ jti, ...payload });
     } else {
-      super(id);
+      super(jti);
     }
   }
 
+  get uid() {
+    return this.jti;
+  }
+
+  set uid(value) {
+    this.jti = value;
+  }
+
   async save(ttl) {
     if (typeof ttl !== 'number') {
       throw new TypeError('"ttl" argument must be a number');
@@ -56,7 +64,6 @@ module.exports = (provider) => class Interaction extends hasFormat(provider, 'In
       'returnTo',
       'signed',
       'grantId',
-      'uid',
       'lastSubmission',
       'deviceCode',
     ];

diff --git a/test/configuration/interaction_url.test.js b/test/configuration/interaction_url.test.js
@@ -16,7 +16,7 @@ describe('pathFor related behaviors', () => {
       },
     });
 
-    const url = await i(provider).configuration('interactions.url')({}, { uid: 'foobar' });
+    const url = await i(provider).configuration('interactions.url')({}, new provider.Interaction('foobar', {}));
 
     expect(url).to.equal('/interaction/foobar');
   });