init-pants action fails in curl command after #21

[rajeshwar-nu]

PR #21 introduced using ${{ runner.temp }} instead of temp directory /tmp to download get-pants script.
The curl command fails with error curl: (23) Failure writing output to destination since the default worker temp directory /home/runner/work/_temp does not exist.
The fix would be to use flag https://curl.se/docs/manpage.html#--create-dirs which will create the directory if it does not exists.
The final command would look like this
curl --create-dirs --proto '=https' --tlsv1.2 -fsSLo ${{ runner.temp }}/get-pants.sh

[kaos]

Thanks for the report @rajeshwar-nu.
PR welcome if you want to submit that change to speed up the process :)

[benjyw]

Ooof, that is super annoying, that runner.temp doesn't exist... @rajeshwar-nu a PR would be most welcome! Thanks.

[eguiraud]

We just got hit by this issue from May last year -- it's still present in the latest v8 tag.

Adding this step before the init-pants action works around the problem, but it would be great to have a fix upstream:

- name: Create runner.temp
  run: |
    # work around https://github.com/pantsbuild/actions/issues/22
    mkdir -p ${{ runner.temp }}

[benjyw]

@eguiraud Could you send a PR in this repo with the fix? Thanks!

[eguiraud]

I am not sure whether the one above is the most appropriate fix (nor, if it is, where to put it exactly in this repo)

[benjyw]

That seems like the right fix to me. Adding --create-dirs to the curl command works, but only for curl, and if in the future some change tries to use the temp dir in a different way, it would fail again. And the change would go here: https://github.com/pantsbuild/actions/blob/main/init-pants/action.yaml

HOWEVER... @eguiraud Are you running in a container? The issue may be actions/runner#965, in which case none of these solutions are robust. The container user may or may not be able to mkdir, but you'd be creating a container tempdir at a path that only makes sense on the host, which is sketchy.