Skip to content

Commit 6afb1d2

Browse files
jazzsequenceJohn Spellmandependabot[bot]
authored
Release 1.3.4 (#240)
* Update images for lint and test-behat jobs * Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4 * Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#229) Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0. - [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases) - [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator) - [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0) --- updated-dependencies: - dependency-name: dealerdirect/phpcodesniffer-composer-installer dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [CMSP-79] PHP 8.2 (#232) * Bump grunt from 1.5.3 to 1.6.1 (#235) * fix GPL license version (#236) * Add CMS Platform to CODEOWNERS (#239) * [BUGS-5809] Add fallback for $session->get_data() (#237) * fix GPL license version * add a fallback if $session is not null but the ->get_data is this creates a PHP warning It's possible this might escallate to a fatal in PHP 8+ Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/ * exclude short ternaries being disallowed I fundamentally disagree with the guidance that they are "rarely used correctly" * bump version * update/add changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: John Spellman <john.spellman@pantheon.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 parent 6e83dd3 commit 6afb1d2

File tree

9 files changed

+92
-102
lines changed

9 files changed

+92
-102
lines changed

CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
* @pantheon-systems/cms-ecosystem
2+
* @pantheon-systems/cms-platform

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
**Tags:** comments, sessions
44
**Requires at least:** 4.7
55
**Tested up to:** 6.1
6-
**Stable tag:** 1.3.3
6+
**Stable tag:** 1.3.4
77
**Requires PHP:** 5.4
88
**License:** GPLv2 or later
99
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html
@@ -71,6 +71,12 @@ This mu-plugin will load WP Native PHP Sessions before all other plugins, while
7171

7272
## Changelog ##
7373

74+
### 1.3.4 (February 7, 2023) ###
75+
* Add fallback for $session->get_data() [[#237(https://github.com/pantheon-systems/wp-native-php-sessions/pull/237)]] (reported [on WordPress.org](https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/))
76+
* Update CODEOWNERS file [[#239](https://github.com/pantheon-systems/wp-native-php-sessions/pull/239)]
77+
* Fix GPL license in `composer.json` file [[#236](https://github.com/pantheon-systems/wp-native-php-sessions/pull/236)]
78+
* Bump grunt from 1.5.3 to 1.6.1 [[#235](https://github.com/pantheon-systems/wp-native-php-sessions/pull/235)]
79+
7480
### 1.3.3 (January 25, 2023) ###
7581
* Bump version in pantheon-sessions.php [[#234](https://github.com/pantheon-systems/wp-native-php-sessions/pull/234)].
7682

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "pantheon-systems/wp-native-php-sessions",
33
"description": "native PHP sessions stored in the database for WordPress.",
44
"type": "wordpress-plugin",
5-
"license": "GPLv2 or later",
5+
"license": "GPL-2.0-or-later",
66
"authors": [
77
{
88
"name": "Pantheon",

inc/class-session-handler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function read( $session_id ) {
7171

7272
$session = Session::get_by_sid( $session_id );
7373
if ( $session ) {
74-
return $session->get_data();
74+
return $session->get_data() ?: '';
7575
} else {
7676
return '';
7777
}

0 commit comments

Comments
 (0)