Skip to content

Conversation

@lyricat
Copy link

@lyricat lyricat commented Oct 27, 2025

try to fix #63


Summary by cubic

Fix double-escaping of link URLs in the Markdown parser so the displayed URL isn’t escaped twice. The anchor href remains sanitized; resolves #63.

panphora added a commit that referenced this pull request Nov 3, 2025
This commit addresses multiple community-reported issues and PRs:

- Fix PR #62: Toolbar option now properly respected in reinit() with memory leak protection
- Fix Issue #65: Code block alignment issues with white-space and font-family CSS
- Fix PR #64/Issue #63: Double-escaping of URLs with query parameters
- Fix Issue #52: Layer sync bug when switching between editor modes
- Fix Issue #54: Add instance setTheme() method for per-editor theming

New features:
- Add showNormalEditMode(), showPreviewMode(), showPlainTextarea() methods
- Migrate from CSS classes to data-mode attribute for cleaner state management
- Add comprehensive test coverage for links (9 new tests) and mode switching

Technical improvements:
- Toolbar lifecycle now managed through _applyOptions() with proper cleanup
- All 155 tests passing with requestAnimationFrame mocks for Node.js environment
- Updated TypeScript definitions for new methods and return types
@panphora
Copy link
Owner

panphora commented Nov 6, 2025

Thank you @lyricat! Your fix was architecturally correct - applied as-is.

Added extensive test coverage to prevent regression. Closes #63.

Merged!

@panphora panphora closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the URL gets html escaped twice

2 participants