fix toolbar option being ignored in reinit #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panphora
added a commit
that referenced
this pull request
Nov 3, 2025
This commit addresses multiple community-reported issues and PRs: - Fix PR #62: Toolbar option now properly respected in reinit() with memory leak protection - Fix Issue #65: Code block alignment issues with white-space and font-family CSS - Fix PR #64/Issue #63: Double-escaping of URLs with query parameters - Fix Issue #52: Layer sync bug when switching between editor modes - Fix Issue #54: Add instance setTheme() method for per-editor theming New features: - Add showNormalEditMode(), showPreviewMode(), showPlainTextarea() methods - Migrate from CSS classes to data-mode attribute for cleaner state management - Add comprehensive test coverage for links (9 new tests) and mode switching Technical improvements: - Toolbar lifecycle now managed through _applyOptions() with proper cleanup - All 155 tests passing with requestAnimationFrame mocks for Node.js environment - Updated TypeScript definitions for new methods and return types
Owner
|
Thank you @kristiankostecky! This fix is excellent. Applied in v2.0 with an additional enhancement: added proper cleanup of button event listeners in the destroy() method to prevent memory leaks during reinit cycles. All 178 tests passing. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
reinit()to re-initialize the editor with updated options, changes to the toolbar option were being ignored. The toolbar was only created during the initial constructor call, making it impossible to dynamically enable/disable the toolbar after initialization.Fixed by movin toolbar lifecycle management to
_applyOptions()Summary by cubic
Fixes the toolbar option being ignored on reinit(). The editor now creates or destroys the toolbar based on updated options so it can be enabled or disabled dynamically.