detect json as javascript

[lepture]

detect json as javascript. json is valid javascript.

[millermedeiros]

JSON isn't JavaScript! I use syntastic + jsonlint to validate my JSON files during save and this line breaks it!

[eddiemonge]

I agree. I think this is a bad change. Please remove this or keep it behind an option flag.

[goatslacker]

Hmm let me think about this. JSON is supposed to be a subset of JavaScript so including it with JS syntax highlighting makes sense. I think it's quite overkill to have separate JSON highlighting -- if it's breaking something it's reasonable to fix it or remove it altogether.

Why do you think this is bad @eddiemonge ?

[eddiemonge]

JSON is JavaScript-like but not Javascript. Most (based on tools, usage, etc) lint guidelines recommend using single quotes for JS. JSON however, has to have double quotes to be valid. By telling VIM that JSON IS JS you are locking it into the same strict guidelines. I'd rather use a plugin dedicated solely to JSON like https://github.com/elzr/vim-json to parse it. Or if you do include it in this plugin, target it as JSON and not as JS. JSON has very strict requirements where JS is more laissez-faire

[amadeus]

Agreed with @eddiemonge, essentially since JSON is a hyper strict subset of Javascript, the code will be properly highlighted by our JS plugin, however the code will not be proper JSON.

I use a specific JSON syntax file to work around this.

[goatslacker]

Yeah it makes sense. Feel free to send a pull request.