BUG: Make copies of certain interpolate arguments (GH7295) #7479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any specific tests that need to add (aside from the 32-but failures) thxs |
|
Yep, was looking up my "how to rebase and squash" tutorial right now. I don't think there are any new tests, though. Are minor and obscure notes like this really worth a release note, though? |
|
right - forgot the release note then |
jreback
added a commit
that referenced
this pull request
Jun 17, 2014
BUG: Make copies of certain interpolate arguments (GH7295)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7295
On the alt_methods branch in interpolate_1d, make copies if x, y, and new_x don't have their
writeableattribute set. It seems a little weird that we need to do this, but it'll work around the issue so that the test can pass, anyway.