BUG: is_*_array returns true on empty object dtype #60796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Internals
5 tasks
rhshadrach
commented
Jan 26, 2025
Comment on lines
+146
to
+147
| columns=pd.Index(list("ABCD")), | ||
| index=pd.Index([f"i-{i}" for i in range(30)]), |
There was a problem hiding this comment.
Didn't expect this, but previous behavior looks incorrect. With infer_string=True, was not inferring str and now it is.
WillAyd
reviewed
Jan 27, 2025
| "is_timedelta_or_timedelta64_array", | ||
| ], | ||
| ) | ||
| def test_is_dtype_array_empty_obj(self, func): |
There was a problem hiding this comment.
Do we have test coverage for is_object_array returning True explicitly elsewhere?
There was a problem hiding this comment.
I'm not seeing an is_object_array.
There was a problem hiding this comment.
Ah my mistake - I think I got tripped up the PR title. That should say is_*_array returns false on empty object dtype instead of true right? Or am I overlooking something?
There was a problem hiding this comment.
I suppose it depends how you want the title of a PR constructed. The bug is that it returns true, this PR's title is a statement of the bug.
WillAyd
approved these changes
Jan 27, 2025
Merged
5 tasks
jorisvandenbossche
approved these changes
Jan 28, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Want this in 2.3 for #60795.