BUG: Fixes pd.merge issue with columns of dtype numpy.uintc on windows #60145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pytest test case to verify correct behavior with numpy.uintc dtype
mroeschke
reviewed
Oct 30, 2024
Comment on lines
1847
to
1848
| """To test if pd.merge works with numpy.uintc on windows""" | ||
|
|
There was a problem hiding this comment.
Suggested change
| """To test if pd.merge works with numpy.uintc on windows""" |
We don't use docstrings in our tests
mroeschke
reviewed
Oct 30, 2024
| def test_merge_with_uintc_columns(dataframes_with_uintc): | ||
| """To test if pd.merge works with numpy.uintc on windows""" | ||
|
|
||
| df1 = pd.DataFrame({"a": ["foo", "bar"], "b": np.array([1, 2], dtype=np.uintc)}) |
There was a problem hiding this comment.
Do we have tests with np.intc as well?
mroeschke
reviewed
Oct 30, 2024
| @@ -1843,6 +1843,20 @@ def test_merge_empty(self, left_empty, how, exp): | |||
|
|
|||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_merge_with_uintc_columns(dataframes_with_uintc): | |||
There was a problem hiding this comment.
Suggested change
| def test_merge_with_uintc_columns(dataframes_with_uintc): | |
| def test_merge_with_uintc_columns(): |
Looks like that fixture wasn't used
mroeschke
requested changes
Oct 30, 2024
mroeschke
added
Reshaping
…ile to make pandas namespace consistent
|
Hi @mroeschke , I have added the whatsnew note and included current issue #58713 and also issue #60091 as this PR fixes both of them. I have also added 2 more test cases which includes |
mroeschke
reviewed
Oct 31, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -592,7 +592,6 @@ Performance improvements | |||
| - Performance improvement in :meth:`RangeIndex.take` returning a :class:`RangeIndex` instead of a :class:`Index` when possible. (:issue:`57445`, :issue:`57752`) | |||
| - Performance improvement in :func:`merge` if hash-join can be used (:issue:`57970`) | |||
| - Performance improvement in :meth:`CategoricalDtype.update_dtype` when ``dtype`` is a :class:`CategoricalDtype` with non ``None`` categories and ordered (:issue:`59647`) | |||
| - Performance improvement in :meth:`DataFrame.astype` when converting to extension floating dtypes, e.g. "Float64" (:issue:`60066`) | |||
There was a problem hiding this comment.
Don't think this should have been removed
There was a problem hiding this comment.
Sorry It accidentally got deleted while running a git command. Thank you for catching it
mroeschke
reviewed
Oct 31, 2024
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
approved these changes
Nov 1, 2024
|
Thanks @AbhishekChaudharii |
keitaroyam
added a commit
to keitaroyam/servalcat
that referenced
this pull request
Dec 2, 2024
pandas-dev/pandas#60145 this has been fixed, but not released
keitaroyam
added a commit
to keitaroyam/servalcat
that referenced
this pull request
Dec 2, 2024
pandas-dev/pandas#60145 this has been fixed, but not released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue encountered when using pd.merge with columns of dtype numpy.uintc on windows.
Added a relevant pytest case to validate correct behavior.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.