Use ruff to detect banned import #57184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqa236
force-pushed
the
use-ruff-to-detect-banned-import
branch
2 times, most recently
from
6fc664e
to
bb8bc8f
Compare
mroeschke
reviewed
Feb 3, 2024
.pre-commit-config.yaml
Outdated
| @@ -30,6 +30,10 @@ repos: | |||
| files: ^pandas | |||
| exclude: ^pandas/tests | |||
| args: [--select, "ANN001,ANN2", --fix-only, --exit-non-zero-on-fix] | |||
| - id: ruff | |||
| args: [--exit-non-zero-on-fix, --select=TID251] | |||
There was a problem hiding this comment.
Cant we just add TID251 to the pyproject.toml?
There was a problem hiding this comment.
@mroeschke indeed all the TID rules are already enabled. This new hook is redundant because the first ruff hook can cover it already.
Do you think I need to ignore TID251 in pandas/tests/*? If not, this PR should be ready for review
There was a problem hiding this comment.
TID251 shouldn't be ignored for tests
mroeschke
approved these changes
Feb 5, 2024
|
Thanks @tqa236 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Use ruff to detect banned import * Combine rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several other potential replacement, I just open this PR first to check if this replacement is good or not. The newly added
noqainpandas/io/common.pyshows that the check works.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.