Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement masked algorithm for mode #55340

Merged
merged 8 commits into from
Nov 18, 2023
Merged

Implement masked algorithm for mode #55340

merged 8 commits into from
Nov 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 30, 2023

@phofl phofl requested a review from WillAyd as a code owner September 30, 2023 20:07
@mroeschke mroeschke added the NA - MaskedArrays Related to pd.NA and nullable extension arrays label Oct 2, 2023
@@ -77,7 +77,7 @@ Other enhancements
- :func:`read_csv` now supports ``on_bad_lines`` parameter with ``engine="pyarrow"``. (:issue:`54480`)
- :meth:`ExtensionArray._explode` interface method added to allow extension type implementations of the ``explode`` method (:issue:`54833`)
- DataFrame.apply now allows the usage of numba (via ``engine="numba"``) to JIT compile the passed function, allowing for potential speedups (:issue:`54666`)
- Implement masked algorithms for :meth:`Series.value_counts` (:issue:`54984`)
- Implement masked algorithms for :meth:`Series.value_counts` and :meth:`Series.mode` (:issue:`54984`, :issue:`55340`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users mainly need to know this improves performance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved and reworded

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 15, 2023
@phofl
Copy link
Member Author

phofl commented Nov 16, 2023

planning on merging this soonish if no objections

@phofl phofl removed the Stale label Nov 18, 2023
@phofl phofl added this to the 2.2 milestone Nov 18, 2023
@phofl phofl merged commit 1969079 into pandas-dev:main Nov 18, 2023
39 of 40 checks passed
@phofl phofl deleted the mode branch November 18, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: support masked arrays in hashtable-based functions (duplicated, isin, mode)
3 participants