BUG: add pyarrow autogenerated prefix #55115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 19, 2023
| StringIO(data), | ||
| header=None, | ||
| usecols=[0, 1], | ||
| dtype="object", |
Member
There was a problem hiding this comment.
Can you test with string[pyarrow] here
Contributor
Author
There was a problem hiding this comment.
Sure things. It works fine so long as I make the comparison dataframe string[pyarrow] too of course:
StringIO(data),
header=None,
usecols=[0, 1],
dtype="string[pyarrow]",
dtype_backend="pyarrow",
engine="pyarrow",
)
expected = DataFrame([
["a", "i"], ["b", "j"]],
dtype="string[pyarrow]"
)
tm.assert_frame_equal(result, expected)
I'll update the PR with the change.
mroeschke
reviewed
Sep 19, 2023
mroeschke
reviewed
Sep 19, 2023
… `DataFrame` to ignore passed arguments) (pandas-dev#55089) * fixes pandas-dev#55009 * update documentation * write documentation * add test * change formatting * cite DataDrame directly in docs Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mroeschke
reviewed
Sep 20, 2023
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Member
|
Please review and address the failed pre-commit failure |
Contributor
Author
wasn't seeing any issue in my local pre-commit for some reason |
mroeschke
approved these changes
Sep 27, 2023
Member
|
Thanks @hedeershowk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Any suggestions where to add a test for this bug (and fix)?edit: took a shot and put it in
tests/io/parser/test_header.py