Skip to content

print_versions.py fixes #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from Nov 10, 2013
Merged

print_versions.py fixes #5486

2 commits merged into from Nov 10, 2013

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2013

#4760
#4901

  1. Path resolution was broken, so running the script outside the pandas root directory didn't work.
  2. The use of subprocess to invoke the script from the source tree relied on system python,
    ignoring the interpreter version actually used to invoke the scripts. Travis was unaffected since the system python there
    always matches the python version of the env.
  3. Using subprocess meant Ctrl-C didn't interrupt the script (meh).

cc @cpcloud

ghost pushed a commit that referenced this pull request Nov 10, 2013
@ghost ghost merged commit 5f84c40 into pandas-dev:master Nov 10, 2013
@ghost ghost deleted the PR_pr_ver_fixes branch November 10, 2013 21:48
@cpcloud
Copy link
Member

cpcloud commented Nov 10, 2013

  1. Path resolution was broken, so running the script outside the pandas root directory didn't work.

I tried this. It worked just fine on my end.

Using subprocess meant Ctrl-C didn't interrupt the script (meh).

C'mon, really?

No. 2 makes sense.

@ghost
Copy link
Author

ghost commented Nov 10, 2013

python: can't open file 'pandas/util/print_versions.py': [Errno 2] No such file or directory
Traceback (most recent call last):
  File "./print_versions.py", line 16, in <module>
    show_versions()
  File "./print_versions.py", line 12, in show_versions
    return subprocess.check_call(['python', sv_path])
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['python', 'pandas/util/print_versions.py']' returned non-zero exit status 2

didn't work on my end.


I know, that's what the meh was for.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant