Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MAINT: small simplification of meson.build following best practices" #54802

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 28, 2023

Reverts #54737

cc @lithomas1

@phofl phofl requested a review from WillAyd as a code owner August 28, 2023 12:13
@phofl phofl added this to the 2.1 milestone Aug 28, 2023
@phofl phofl merged commit 0a23624 into main Aug 28, 2023
33 of 35 checks passed
@lumberbot-app
Copy link

lumberbot-app bot commented Aug 28, 2023

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@phofl phofl deleted the revert-54737-meson-best-practices branch August 28, 2023 17:36
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
…ctices" (pandas-dev#54802)

* Revert "MAINT: small simplification of meson.build following best practices (pandas-dev#54737)"

This reverts commit ca42994.

* Update meson.build

* Update meson.build

---------

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants