Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionArray.fillna: start with DeprecationWarning about added copy keyword #54800

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Aug 28, 2023

Follow-up on #53728, changing the FutureWarning to DeprecationWarning. This warning is targetting EA authors, not end users, and thus we should start with a DeprecationWarning.

@jorisvandenbossche jorisvandenbossche added the ExtensionArray Extending pandas with custom dtypes or arrays. label Aug 28, 2023
@jorisvandenbossche jorisvandenbossche added this to the 2.1 milestone Aug 28, 2023
@jorisvandenbossche jorisvandenbossche merged commit 634096f into pandas-dev:main Aug 28, 2023
33 of 37 checks passed
@jorisvandenbossche jorisvandenbossche deleted the fillna-copy branch August 28, 2023 15:10
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 28, 2023
mroeschke pushed a commit that referenced this pull request Aug 28, 2023
… DeprecationWarning about added copy keyword) (#54812)

Backport PR #54800: ExtensionArray.fillna: start with DeprecationWarning about added copy keyword

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants