Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: make arguments keyword only in to_clipboard #54634

Merged
merged 12 commits into from
Aug 22, 2023
Merged

DEPR: make arguments keyword only in to_clipboard #54634

merged 12 commits into from
Aug 22, 2023

Conversation

rsm-23
Copy link
Contributor

@rsm-23 rsm-23 commented Aug 18, 2023 •
edited
Loading

@rsm-23 rsm-23 marked this pull request as ready for review August 19, 2023 05:09
@rsm-23
Copy link
Contributor Author

rsm-23 commented Aug 21, 2023 •
edited
Loading

@mroeschke is anything more required here?
edit: reference to your comment

mroeschke
mroeschke reviewed Aug 21, 2023
View reviewed changes
pandas/core/generic.py Outdated Show resolved Hide resolved
@mroeschke mroeschke added Deprecate Functionality to remove in pandas IO Data IO issues that don't fit into a more specific label labels Aug 21, 2023
mroeschke
mroeschke reviewed Aug 21, 2023
View reviewed changes
pandas/core/generic.py Outdated Show resolved Hide resolved
rsm-23 and others added 2 commits August 22, 2023 00:53
@rsm-23 @mroeschke
Update pandas/core/generic.py
e33cd8b 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@rsm-23
added test
48c696a
@rsm-23
Copy link
Contributor Author

rsm-23 commented Aug 21, 2023

@mroeschke added test for the same.

@rsm-23 rsm-23 requested a review from mroeschke August 21, 2023 20:39
@mroeschke
Copy link
Member

Just a merge conflict that needs fixing

@rsm-23
Copy link
Contributor Author

rsm-23 commented Aug 22, 2023

@mroeschke resolved

@mroeschke mroeschke added this to the 2.2 milestone Aug 22, 2023
@mroeschke mroeschke merged commit cbe88f3 into pandas-dev:main Aug 22, 2023
32 of 33 checks passed
@mroeschke
Copy link
Member

Thanks @rsm-23

@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Open
@rsm-23 rsm-23 deleted the nonkeyword-to-clipboard branch August 22, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rsm-23 @mroeschke