Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NaN as na_value for new pyarrow_numpy StringDtype #54585

Merged
merged 23 commits into from
Aug 26, 2023
Merged

Use NaN as na_value for new pyarrow_numpy StringDtype #54585

merged 23 commits into from
Aug 26, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 16, 2023 •
edited by jorisvandenbossche
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

xref #54792

phofl and others added 15 commits August 13, 2023 14:25
This was referenced Aug 16, 2023
Merged
Merged
@jorisvandenbossche
Copy link
Member

Looking just at the single commit d862eca, that looks good to me

@phofl
Fix typing
606cd71
@phofl
Merge remote-tracking branch 'upstream/main' into string_array_numpy_…
a44b042 
…semantics_na_val

# Conflicts:
#	pandas/tests/arrays/string_/test_string.py
#	pandas/tests/extension/test_string.py
@phofl
Merge remote-tracking branch 'upstream/main' into string_array_numpy_…
3fec6d3 
…semantics_na_val

# Conflicts:
#	pandas/tests/strings/__init__.py
#	pandas/tests/strings/test_split_partition.py
@phofl
Fix
68acc32
@lithomas1 lithomas1 mentioned this pull request Aug 21, 2023
Merged
@phofl
Copy link
Member Author

phofl commented Aug 21, 2023

cc @jbrockmendel

phofl and others added 2 commits August 22, 2023 17:55
@phofl
Update comment
206d08e
@phofl
Merge remote-tracking branch 'upstream/main' into string_array_numpy_…
541c23d 
…semantics_na_val

# Conflicts:
#	pandas/core/arrays/string_arrow.py
#	pandas/tests/arrays/string_/test_string.py
#	pandas/tests/strings/test_case_justify.py
@phofl
Copy link
Member Author

phofl commented Aug 23, 2023

rebased, the diff is more manageable now

cc @jorisvandenbossche @jbrockmendel

@jorisvandenbossche jorisvandenbossche changed the title Add na_val for new String Array Use NaN as na_value for new pyarrow_numpy StringDtype Aug 24, 2023
@phofl
Copy link
Member Author

phofl commented Aug 26, 2023

merging this

@phofl phofl merged commit 9d8bce7 into pandas-dev:main Aug 26, 2023
33 checks passed
@phofl phofl added this to the 2.1 milestone Aug 26, 2023
@phofl phofl added the Arrow pyarrow functionality label Aug 26, 2023
@phofl phofl deleted the string_array_numpy_semantics_na_val branch August 26, 2023 10:40
@phofl
Copy link
Member Author

phofl commented Aug 26, 2023

@meeseeksdev backport to 2.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 26, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 26, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#54585: Use NaN as na_value for new pyarrow_num…
3f1ef89 
…py StringDtype
phofl added a commit that referenced this pull request Aug 26, 2023
@meeseeksmachine @phofl
Backport PR #54585 on branch 2.1.x (Use NaN as na_value for new pyarr…
605aea2 
…ow_numpy StringDtype) (#54767)

Backport PR #54585: Use NaN as na_value for new pyarrow_numpy StringDtype

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@jorisvandenbossche jorisvandenbossche mentioned this pull request Aug 28, 2023
Open
37 tasks
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@phofl @mroeschke
Use NaN as na_value for new pyarrow_numpy StringDtype (pandas-dev#54585)
8e3963b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@jbrockmendel jbrockmendel Awaiting requested review from jbrockmendel

Assignees
No one assigned
Labels
Arrow pyarrow functionality
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @jorisvandenbossche @jbrockmendel