Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixing EX01 - Added examples #54351

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

Sphinx acting weird locally :-/

.. plot::
:context: close-figs

>>> pd.plotting.register_matplotlib_converters()
Copy link
Member

@MarcoGorelli MarcoGorelli Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this line? I think pandas should do it automatically

Could we explain that pandas does this automatically?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then note that if we manually prevent it from happening, then plotting for period fails

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the first line because of Sphinx local fail.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me on green!

Maybe we can reuse same example for deregister_matplotlib_converters - it's close enough, and it enough to teach what the purpose of the method is

@DeaMariaLeon
Copy link
Member Author

DeaMariaLeon commented Aug 1, 2023

Doc build failed

@mroeschke mroeschke added the Docs label Aug 1, 2023
@DeaMariaLeon DeaMariaLeon marked this pull request as ready for review August 1, 2023 16:45
@DeaMariaLeon DeaMariaLeon added this to the 2.1 milestone Aug 1, 2023
@DeaMariaLeon
Copy link
Member Author

It's green

@mroeschke mroeschke merged commit 90d9e25 into pandas-dev:main Aug 1, 2023
36 checks passed
@mroeschke
Copy link
Member

Thanks @DeaMariaLeon

@DeaMariaLeon DeaMariaLeon deleted the 1Aug-2 branch August 1, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants