PDEP6 implementation pt 2: eablock.setitem, eablock.putmask #53405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 13, 2023 12:32
Merged
MarcoGorelli
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
| Deprecated silent upcasting in setitem-like Series operations | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Setitem-like operations on Series (or DataFrame columns) which silently upcast the dtype are |
There was a problem hiding this comment.
Worth listing what methods are setitem-like?
mroeschke
approved these changes
Jul 31, 2023
|
Thanks @MarcoGorelli |
|
@MarcoGorelli do you have time/appetite to start enforcing the PDEP6 deprecation? If not, is enforcing the deprecation as easy as switching the warnings to exceptions or is there more cleanup? |
|
thanks for the ping! yup, I'll get to it - exciting to see it enforced! |
doing it today - sorry for the delay, been too caught up with other work projects, but some of them are winding down now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following on from #50626