Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bug in pd.eval when UnaryOp in function #48511

Merged
merged 6 commits into from
Sep 14, 2022

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Sep 12, 2022

I ran into a similar issue, and added it in test. They both produce AttributeError: 'UnaryOp' object has no attribute 'value'.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a whatsnew not in 1.6.0.rst (in Conversion section)?

@mroeschke mroeschke added the expressions pd.eval, query label Sep 12, 2022
@yuanx749
Copy link
Contributor Author

Could you add a whatsnew not in 1.6.0.rst (in Conversion section)?

Added.

@mroeschke mroeschke added this to the 1.6 milestone Sep 14, 2022
@mroeschke mroeschke merged commit 2b2720a into pandas-dev:main Sep 14, 2022
@mroeschke
Copy link
Member

Thanks @yuanx749

@yuanx749 yuanx749 deleted the neg-in-eval branch September 15, 2022 01:06
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* Fix bug in pd.eval when negative value in function

* Fix test

* Add whatsnew

* Change name check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expressions pd.eval, query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: .fillna(-1) does not work in pd.eval
2 participants