ENH: Support mask in unique #48109
ENH: Support mask in unique #48109
Conversation
pandas/core/algorithms.py
Outdated
|
|
||
|
|
||
| def unique(values): | ||
| def unique(values, mask=None): |
There was a problem hiding this comment.
Not sure if this is a good idea, since this changes the api. A better alternative would probably be a _unique function that can take a mask
There was a problem hiding this comment.
agreed
also can annotate mask?
There was a problem hiding this comment.
Yep, will do when moving to a private function
phofl
added
Algos
|
This probably closes #30037 |
pandas/core/arrays/masked.py
Outdated
| ------- | ||
| uniques : BaseMaskedArray | ||
| """ | ||
| uniques, mask = algos._unique(self._data, self._mask) |
There was a problem hiding this comment.
nitpick, can you rename the function to something non-private, e.g. unique_with_mask
| The labels from values to uniques | ||
| mask : ndarray[bool], optional | ||
| If not None, the mask is used as indicator for missing values | ||
| (True = missing, False = valid) instead of `na_value` or |
There was a problem hiding this comment.
Was this meant to be added to the Parameters section?
(although actually also the return value changes if passing a mask, maybe that can be clarified as well)
There was a problem hiding this comment.
Yes thanks. Moved the mask part up and added a result_mask return value
|
Would merge tomorrow if no objections |
|
Thanks @phofl ! |
4 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jorisvandenbossche