Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Added test for frequency retention in categorical constructor #46779

Merged
merged 5 commits into from
Apr 18, 2022

Conversation

andjhall
Copy link
Contributor

@andjhall andjhall commented Apr 14, 2022

@andjhall
Copy link
Contributor Author

@bgollop contributed

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Apr 16, 2022
@mroeschke mroeschke added this to the 1.5 milestone Apr 18, 2022
@mroeschke mroeschke merged commit f478e30 into pandas-dev:main Apr 18, 2022
@mroeschke
Copy link
Member

Thanks @andjhall (failure unrelated)

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…andas-dev#46779)

* Added test for github issue pandas-dev#33830 to test that categorical was preserving DateTimeIndex freq attribute

* Added an additional test for value_counts preserving frequency

* Modified tests in test_constructors.py to pass the pre-commit check

* Removed tests from test_constructors that were not needed

* Moved categorical freq retention test to pandas/tests/arrays/categorical/

Co-authored-by: Brian Gollop <bgollop@umich.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants