Fix snappy version #46347
Merged
Fix snappy version #46347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should we also add |
Member
Yes should be added to: actions-38.yaml And noted in |
jonashaag
force-pushed
the
fix-snappy-version
branch
from
6da73a7 to
030f028
Compare
| # brotli doesn't contain attributes to confirm it's version | ||
| return "" | ||
| if module.__name__ == "snappy": | ||
| # snappy doesn't contain attributes to confirm it's version |
Member
There was a problem hiding this comment.
snappy.__version__ for me says "3.0.3"
Contributor
Author
There was a problem hiding this comment.
Are you confusing it with https://snappy.math.uic.edu/?
mroeschke
approved these changes
Mar 15, 2022
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Awesome, thanks for alphabetizing too. LGTM
Contributor
|
thanks @jonashaag |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Mar 29, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #46260
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.