Skip to content

BUG: Change numeric_only default to True #46096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 18, 2022
Merged

BUG: Change numeric_only default to True #46096

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d98e262
BUG: Change numeric_only default to True
NumberPiOso Feb 21, 2022
0db8e52
Add future warning numeric_only in DataFrame.quantile
NumberPiOso Feb 23, 2022
c427795
Add deprecations.quantile_datetime_timedelta_colums in whatsnew
NumberPiOso Feb 23, 2022
fcf37a8
Add stacklevel to warning in DataFrame.quantile
NumberPiOso Feb 23, 2022
7e1d286
Modify test to expect warning in test_quantile.py
NumberPiOso Feb 23, 2022
a5e6def
Ignore FutureWarning at test_quantile.py
NumberPiOso Feb 23, 2022
108bb45
Correct documentation numeric_only inDataFrame.quantile
NumberPiOso Feb 24, 2022
93c5f65
DEPR: Specify nodefault for numeric_only default
NumberPiOso Mar 1, 2022
0f37c30
DEPR: Update whatsnew #7308
NumberPiOso Mar 2, 2022
a324dc9
DEPR: Correct frame.quantile tests to specify numeric_only
NumberPiOso Mar 2, 2022
82db984
DEPR: Correct message error frame.quantile
NumberPiOso Mar 2, 2022
9e9b7a9
DEPR: Remove warning filtering DataFrame.quantile
NumberPiOso Mar 3, 2022
67f2cfa
DEPR: Update whatsnew doc about numeric_only attribute
NumberPiOso Mar 3, 2022
42e7df4
DEPR: Update Examples in docs frame.quantile
NumberPiOso Mar 3, 2022
d0a1221
DEPR: Correct test finalize DataFrame.quantile
NumberPiOso Mar 3, 2022
377cc54
Revert "DEPR: Correct frame.quantile tests to specify numeric_only"
NumberPiOso Mar 8, 2022
b460aa2
DEPR: Update tests of quantile with non num cols"
NumberPiOso Mar 8, 2022
7194d13
DEPR: Raise warning frame.quantile with numeric_only
NumberPiOso Mar 8, 2022
f5f7a3e
DEPR: Update doctests quantile, numeric only
NumberPiOso Mar 8, 2022
16e5fc2
DEPR: Correct test_numeric_only_default_false_warning
NumberPiOso Mar 10, 2022
b88b196
DEPR: Add non numeric test to numeric_only warning
NumberPiOso Mar 10, 2022
db68bf2
DERP: correct_test_produces_warning in frame.quantile
NumberPiOso Mar 10, 2022
4438118
Merge remote-tracking branch 'upstream/main' into ench-quantile-numer…
NumberPiOso Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DEPR: Remove warning filtering DataFrame.quantile
  • Loading branch information
@NumberPiOso
NumberPiOso committed Mar 9, 2022
commit 9e9b7a93a9d75b7c32ef3397ff033017d274a561
5 changes: 0 additions & 5 deletions pandas/tests/frame/methods/test_quantile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ def test_quantile_multi(self):
)
tm.assert_frame_equal(result, expected)

@pytest.mark.filterwarnings("ignore:In future versions of pandas, numeric_only")
def test_quantile_datetime(self):
df = DataFrame({"a": pd.to_datetime(["2010", "2011"]), "b": [0, 5]})

Expand Down Expand Up @@ -339,7 +338,6 @@ def test_quantile_invalid(self, datetime_frame):
with pytest.raises(ValueError, match=msg):
datetime_frame.quantile(invalid)

@pytest.mark.filterwarnings("ignore:In future versions of pandas, numeric_only")
def test_quantile_box(self):
df = DataFrame(
{
Expand Down Expand Up @@ -463,7 +461,6 @@ def test_quantile_box(self):
)
tm.assert_frame_equal(res, exp)

@pytest.mark.filterwarnings("ignore:In future versions of pandas, numeric_only")
def test_quantile_nan(self):

# GH 14357 - float block where some cols have missing values
Expand Down Expand Up @@ -532,7 +529,6 @@ def test_quantile_nat(self):
)
tm.assert_frame_equal(res, exp)

@pytest.mark.filterwarnings("ignore:In future versions of pandas, numeric_only")
def test_quantile_empty_no_rows_floats(self):

# floats
Expand Down Expand Up @@ -584,7 +580,6 @@ def test_quantile_empty_no_rows_dt64(self):
exp = exp.astype(df["b"].dtype)
tm.assert_series_equal(res, exp)

@pytest.mark.filterwarnings("ignore:In future versions of pandas, numeric_only")
def test_quantile_empty_no_columns(self):
# GH#23925 _get_numeric_data may drop all columns
df = DataFrame(pd.date_range("1/1/18", periods=5))
Expand Down