Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: Ignore numpy related issues #45244

Merged
merged 9 commits into from
Jan 10, 2022
Merged

TYP: Ignore numpy related issues #45244

merged 9 commits into from
Jan 10, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 7, 2022

This worked for me locally

@pep8speaks
Copy link

pep8speaks commented Jan 7, 2022 •
edited
Loading

Hello @phofl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-07 13:25:05 UTC

@jreback jreback added this to the 1.4 milestone Jan 8, 2022
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Jan 8, 2022
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

@phofl i think i merged some things, can you merge master and ping when ready

@phofl
Merge remote-tracking branch 'upstream/master' into typ_new_numpy
bd00bd6 
# Conflicts:
#	pandas/core/arrays/masked.py
#	pandas/core/dtypes/cast.py
#	pandas/core/indexes/base.py
#	pandas/core/reshape/reshape.py
@jreback jreback merged commit d603d43 into pandas-dev:master Jan 10, 2022
@lumberbot-app

This comment has been minimized.

Sign in to view
@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

thanks @phofl hopefully this should backport

@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

hmm i guess not, if you can push a manula backport @phofl

@phofl
Copy link
Member Author

phofl commented Jan 10, 2022

Will try to setup a pr in the evening

phofl added a commit to phofl/pandas that referenced this pull request Jan 11, 2022
@phofl
TYP: Ignore numpy related issues (pandas-dev#45244)
2d6bcda 
(cherry picked from commit d603d43)
simonjayhawkins pushed a commit that referenced this pull request Jan 15, 2022
@phofl
Backport PR #45244 on branch 1.4.x (TYP: Ignore numpy related issues) (…
638a42f 
…#45306)
@simonjayhawkins simonjayhawkins mentioned this pull request Jan 15, 2022
Merged
@phofl phofl deleted the typ_new_numpy branch January 28, 2022 10:26
@twoertwein twoertwein mentioned this pull request Jun 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein left review comments

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@phofl @pep8speaks @jreback @twoertwein @simonjayhawkins