DOC: df.to_html documentation incorrectly contains min_rows optional param (release note) #44506
Conversation
loicdiridollou
commented
Nov 18, 2021
loicdiridollou
commented
- closes DOC: df.to_html documentation incorrectly contains min_rows optional param #44304
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -212,6 +212,7 @@ Other enhancements | |||
| - :meth:`.GroupBy.mean` now supports `Numba <http://numba.pydata.org/>`_ execution with the ``engine`` keyword (:issue:`43731`) | |||
| - :meth:`Timestamp.isoformat`, now handles the ``timespec`` argument from the base :class:``datetime`` class (:issue:`26131`) | |||
| - :meth:`NaT.to_numpy` ``dtype`` argument is now respected, so ``np.timedelta64`` can be returned (:issue:`44460`) | |||
| - Change in the order of the arguments in :meth:`DataFrame.to_string` due to change in the docstring (:issue:`44304`) | |||
There was a problem hiding this comment.
This should go under Other API changes and mention that min_rows was affected.
There was a problem hiding this comment.
You are correct! Updated it, waiting for tests to run, surprisingly some workflows either got cancelled or failed for no obvious reasons, will look into it
There was a problem hiding this comment.
Some tests are breaking but it is not related to my code, have seen these failed in other PRs
FAILED pandas/tests/plotting/test_hist_method.py::TestDataFrameGroupByPlots::test_axis_share_x
FAILED pandas/tests/plotting/test_hist_method.py::TestDataFrameGroupByPlots::test_axis_share_y
FAILED pandas/tests/plotting/test_hist_method.py::TestDataFrameGroupByPlots::test_axis_share_xy
FAILED pandas/tests/plotting/test_series.py::TestSeriesPlots::test_area_sharey_dont_overwrite
FAILED pandas/tests/plotting/frame/test_frame.py::TestDataFramePlots::test_area_sharey_dont_overwrite
FAILED pandas/tests/plotting/frame/test_hist_box_by.py::TestHistWithBy::test_axis_share_x_with_by
FAILED pandas/tests/plotting/frame/test_hist_box_by.py::TestHistWithBy::test_axis_share_y_with_by
There was a problem hiding this comment.
Bugs in the CI Docs and web related to #44494, no idea why but all the recent PRs have this error
|
Mentioning the failed tests in the following issue #44521 |
doc/source/whatsnew/v0.9.1.rst
Outdated
| @@ -59,7 +59,7 @@ New features | |||
|
|
|||
| .. ipython:: python | |||
|
|
|||
| df = DataFrame(np.random.randn(5, 3), columns = ['A','B','C']) | |||
| df = pd.DataFrame(np.random.randn(5, 3), columns = ['A','B','C']) | |||
There was a problem hiding this comment.
Please revert this change (the CI is having issue unrelated to this PR)
There was a problem hiding this comment.
It was raising a warning on my machine when building but does not seem to be the case on the builder in GH so reverted
|
Thanks @loicdiridollou |
