Skip to content

DEPR: Passing in a string column label for DataFrame.ewm(times=...) #43265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 5, 2021
Merged

DEPR: Passing in a string column label for DataFrame.ewm(times=...) #43265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eca6429
DEPR: Passing in a string column label for DataFrame.ewm(times=...)
mroeschke Aug 27, 2021
14971e4
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Aug 27, 2021
db0ca21
add PR number
mroeschke Aug 27, 2021
95a99ae
Technically not mean
mroeschke Aug 27, 2021
89226c2
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Aug 29, 2021
0b5a847
use find_stack_level
mroeschke Aug 29, 2021
5ad394b
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Aug 31, 2021
d7781ab
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Aug 31, 2021
3f855ba
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Sep 1, 2021
a1cb6cc
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Sep 2, 2021
77b25d3
Merge remote-tracking branch 'upstream/master' into depr/ewm_times_col
mroeschke Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add PR number
  • Loading branch information
@mroeschke
mroeschke committed Aug 27, 2021
commit db0ca21b1f295b4b5709ce50138e811d6e3e9f19
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.4.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ Deprecations
- Deprecated dropping of nuisance columns in :class:`Rolling`, :class:`Expanding`, and :class:`EWM` aggregations (:issue:`42738`)
- Deprecated :meth:`Index.reindex` with a non-unique index (:issue:`42568`)
- Deprecated :meth:`.Styler.render` in favour of :meth:`.Styler.to_html` (:issue:`42140`)
- Deprecated passing in a string column label into ``times`` in :meth:`DataFrame.ewm` (:issue:``)
- Deprecated passing in a string column label into ``times`` in :meth:`DataFrame.ewm.mean` (:issue:`43265`)

.. ---------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/window/test_ewm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def test_float_dtype_ewma(func, expected, float_numpy_dtype):


def test_times_string_col_deprecated():
# GH
# GH 43265
data = np.arange(10.0)
data[::2] = np.nan
df = DataFrame({"A": data, "time_col": date_range("2000", freq="D", periods=10)})
Expand Down