-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: Handle zero-chunked pyarrow.ChunkedArray in StringArray #41052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
3dab96d
e97ad97
f4a2c8c
58736a6
5ce19cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -126,7 +126,12 @@ def __from_arrow__( | |||||
bool_arr = BooleanArray._from_sequence(np.array(arr)) | ||||||
results.append(bool_arr) | ||||||
|
||||||
return BooleanArray._concat_same_type(results) | ||||||
if not results: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
? (I find that more explicit / readable) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whoops, missed that comment. Sorry for the contradicting feedback ;) (let's leave it for now then, something to discuss / agree on as pandas team) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Saw this on a few prs in the past that either not was used or it was recommended to use not, hence my feedback, sorry if I misinterpreted this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
No, no, nothing to be sorry about! I know that others prefer that and give that feedback, I personally just don't agree with it being a better style ;) |
||||||
return BooleanArray( | ||||||
np.array([], dtype=np.bool_), np.array([], dtype=np.bool_) | ||||||
) | ||||||
else: | ||||||
return BooleanArray._concat_same_type(results) | ||||||
|
||||||
|
||||||
def coerce_to_array( | ||||||
|
Uh oh!
There was an error while loading. Please reload this page.