Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: move Styler format tests to own module #40641

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

attack68
Copy link
Contributor

The following tests moved from style/test_style.py to their own module style/test_format.py.

def test_display_format(styler):
def test_format_dict(styler):
def test_format_string(styler): [added new]
def test_format_callable(styler): [added new]
def test_format_with_na_rep():
def test_format_non_numeric_na():
def test_format_clear(styler):
def test_format_escape():
def test_format_escape_na_rep():
def test_format_escape_floats(styler):
def test_format_raises(styler, formatter):
def test_format_with_precision():
def test_format_subset():

The new module does not use class setup structure.

@pep8speaks
Copy link

Hello @attack68! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 32:89: E501 line too long (91 > 88 characters)
Line 34:89: E501 line too long (97 > 88 characters)
Line 38:89: E501 line too long (98 > 88 characters)
Line 43:89: E501 line too long (120 > 88 characters)
Line 72:89: E501 line too long (90 > 88 characters)

@attack68
Copy link
Contributor Author

Hello @attack68! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 32:89: E501 line too long (91 > 88 characters)
Line 34:89: E501 line too long (97 > 88 characters)
Line 38:89: E501 line too long (98 > 88 characters)
Line 43:89: E501 line too long (120 > 88 characters)
Line 72:89: E501 line too long (90 > 88 characters)

This is quite odd since these lines are not long and don't have more than 88 chars in them!?

@jreback jreback added Styler conditional formatting using DataFrame.style Testing pandas testing functions or related to the test suite labels Mar 26, 2021
@jreback jreback added this to the 1.3 milestone Mar 26, 2021
@jreback
Copy link
Contributor

jreback commented Mar 26, 2021

Hello @attack68! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 32:89: E501 line too long (91 > 88 characters)
Line 34:89: E501 line too long (97 > 88 characters)
Line 38:89: E501 line too long (98 > 88 characters)
Line 43:89: E501 line too long (120 > 88 characters)
Line 72:89: E501 line too long (90 > 88 characters)

This is quite odd since these lines are not long and don't have more than 88 chars in them!?

maybe the bot is having an off day :-<

@jreback jreback merged commit f354f08 into pandas-dev:master Mar 26, 2021
@jreback
Copy link
Contributor

jreback commented Mar 26, 2021

thanks @attack68

@attack68 attack68 deleted the test_format branch March 27, 2021 07:14
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
Co-authored-by: JHM Darbyshire (iMac) <attack68@users.noreply.github.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Co-authored-by: JHM Darbyshire (iMac) <attack68@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants