Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add hook for Disallow bare pytest.raises #38799

Merged
merged 5 commits into from
Jan 3, 2021
Merged

TST: Add hook for Disallow bare pytest.raises #38799

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
228aa76
add hook for disallowing bare pytest raises
MarcoGorelli Dec 30, 2020
53e48c7
Merge remote-tracking branch 'upstream/master' into disallow-bare-pyt…
MarcoGorelli Jan 1, 2021
79e7c03
narrow down excludes based on latest merged PRs
MarcoGorelli Jan 1, 2021
6b86460
Merge remote-tracking branch 'upstream/master' into disallow-bare-pyt…
MarcoGorelli Jan 2, 2021
f6f7cf7
Merge remote-tracking branch 'upstream/master' into disallow-bare-pyt…
MarcoGorelli Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,13 @@ repos:
entry: python scripts/validate_unwanted_patterns.py --validation-type="private_function_across_module"
types: [python]
exclude: ^(asv_bench|pandas/tests|doc)/
- id: unwanted-patterns-bare-pytest-raises
name: Check for use of bare pytest raises
language: python
entry: python scripts/validate_unwanted_patterns.py --validation-type="bare_pytest_raises"
types: [python]
files: ^pandas/tests/
exclude: ^pandas/tests/(arrays|computation|dtypes|extension|indexes|indexing|io|libs|reductions|resample|reshape|series|window)/
Copy link
Member

@moink moink Dec 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can wait a day or two we can probably get this down to the much shorter list
^pandas/tests/(computation|extension|indexing|io|series)/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure - or, we could get this is now, and then we each PR you submit you narrow it down further?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 open PRs: #38720, #38800, #38804, #38805. If we edit this line in each of them they will all have merge conflicts with each other.

After those 4 are closed, I am happy to get this one merged and address this line in each future PR, because what's left are the ones that aren't super straightforward and I might need some help with them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i agree, let's wait on this for a little

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, makes sense - have updated and it's much shorter now, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now down to just extension and can merge this, and imo close #30999

- id: inconsistent-namespace-usage
name: 'Check for inconsistent use of pandas namespace in tests'
entry: python scripts/check_for_inconsistent_pandas_namespace.py
Expand Down