TST: Add hook for Disallow bare pytest.raises #38799
Conversation
MarcoGorelli
force-pushed
the
disallow-bare-pytest-raises
branch
from
bf916d4 to
c01011a
Compare
MarcoGorelli
force-pushed
the
disallow-bare-pytest-raises
branch
from
c01011a to
228aa76
Compare
.pre-commit-config.yaml
Outdated
| entry: python scripts/validate_unwanted_patterns.py --validation-type="bare_pytest_raises" | ||
| types: [python] | ||
| files: ^pandas/tests/ | ||
| exclude: ^pandas/tests/(arrays|computation|dtypes|extension|indexes|indexing|io|libs|reductions|resample|reshape|series|window)/ |
There was a problem hiding this comment.
If you can wait a day or two we can probably get this down to the much shorter list
^pandas/tests/(computation|extension|indexing|io|series)/
There was a problem hiding this comment.
sure - or, we could get this is now, and then we each PR you submit you narrow it down further?
There was a problem hiding this comment.
There are 4 open PRs: #38720, #38800, #38804, #38805. If we edit this line in each of them they will all have merge conflicts with each other.
After those 4 are closed, I am happy to get this one merged and address this line in each future PR, because what's left are the ones that aren't super straightforward and I might need some help with them.
There was a problem hiding this comment.
yeah i agree, let's wait on this for a little
There was a problem hiding this comment.
sure, makes sense - have updated and it's much shorter now, thanks!
There was a problem hiding this comment.
We are now down to just extension and can merge this, and imo close #30999
|
looks reasonable, can you rebase once more |
|
thanks @MarcoGorelli |
xref #30999
Adding a hook with lots of excluded folders (for now), this can be made stricter as we go along, there's not that much left