DEPR: Hide deprecated attrs _AXIS_NAMES & _AXIS_NUMBERS #38740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/tests/frame/test_api.py
Outdated
Comment on lines
339
to
343
| with warnings.catch_warnings(record=True) as wrn: | ||
| # _AXIS_NUMBERS, _AXIS_NAMES lookups | ||
| inspect.getmembers(df) | ||
|
|
||
| # some versions give FutureWarning, others DeprecationWarning | ||
| assert len(wrn) | ||
| assert any(x.category in [FutureWarning, DeprecationWarning] for x in wrn) | ||
| # some versions may give FutureWarning, others DeprecationWarning | ||
| assert not len(wrn) |
Member
There was a problem hiding this comment.
This seems like unrelated to the actual test for constructor_expanddim. Maybe split it in two separate tests?
jorisvandenbossche
approved these changes
Dec 28, 2020
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks for the update!
We could maybe add a small 1.2.1 whatsnew note, not sure if it is worth it
jreback
reviewed
Dec 28, 2020
pandas/tests/frame/test_api.py
Outdated
| def test_inspect_getmembers(self): | ||
| # GH38740 | ||
| df = DataFrame() | ||
|
|
Contributor
There was a problem hiding this comment.
could use assert_produces_warning(None) here, but really nobd.
jreback
requested changes
Dec 28, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
i think a note is warrented here in 1.2.1 in the deprecation section is fine
Contributor
Author
|
Updated. |
jreback
approved these changes
Dec 28, 2020
Contributor
|
thanks @topper-123 very nice! |
Contributor
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 28, 2020
… & _AXIS_NUMBERS
jreback
pushed a commit
that referenced
this pull request
Dec 28, 2020
…UMBERS (#38755) Co-authored-by: Terji Petersen <contribute@tensortable.com>
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffUsers that do e.g.
[getattr(pd.DataFrame, x) for x in dir(pd.DataFrame())]orinspect.getmembers(pd.DataFrame())currently get an unfriendly deprecation warning. This fixes that by adding_AXIS_NAMES&_AXIS_NUMBERSto_hidden_attrs.@JSunRae, is it possible for you to add this to your pandas source code and see if this fixes your problem?
xref: #33637